Repository navigation
feat: remove delete-by-type and add delete-by-id for catalog entities - #247
Merged
Merged
Conversation
… entity deletion Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replaces the removed delete-by-type with the safer delete-entities-by-id endpoint, which requires explicit CIDs rather than a broad type filter. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jeff-schnitter
changed the title
- Accepts --file/-f with one CID per line as an alternative to --id/-i flags - Hidden --batch-size param (default 100) controls API call batching for large files - Validates that exactly one of --id or --file is provided Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catalog delete-by-typeCLI command, which allowed bulk-deleting all entities of a given type — motivated by a customer incident where this accidentally wiped all their entitiescatalog delete-by-idas a safer replacement, using the new delete-entities-by-id API which requires explicit CIDs (e.g.en2da8159dbeefb974) rather than a broad type filterUsage:
Test plan
cortex catalog delete-by-typeis no longer availablecortex catalog delete-by-id --id <cid>deletes the specified entity--idflags delete multiple entitiesjust test-allto confirm no regressionsNotes
The
test_perf_rate_limiting.pytest calls the underlying API directly for cleanup — unaffected by this change.The next version will be 1.47.0 (minor bump from the
feat:commit).🤖 Generated with Claude Code