Repository navigation
Conversation
Siddhant-K-code
self-requested a review
October 19, 2026 12:33
Siddhant-K-code
left a comment
Siddhant-K-code
left a comment
Collaborator
There was a problem hiding this comment.
Checked this end to end with a headless Chromium harness that renders the real Markdown component under the same CSP as chat-view.ts. Lazy chunk loading and the script nonce work, with no CSP violations.
Inline comments cover four bugs I reproduced (HC Light theme, state reset while streaming, silent render failures, shared DOMPurify hooks) plus two nits.
Co-authored-by: Siddhant Khare <Siddhantkhare2694@gmail.com>
Deploying github1s with
|
| Latest commit: |
fd32042
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://56a31a53.github1s-dld.pages.dev |
| Branch Preview URL: | https://dev.github1s-dld.pages.dev |
Co-authored-by: Siddhant Khare <Siddhantkhare2694@gmail.com>
Owner
Author
|
@Siddhant-K-code Thank you for your review, I have made the fixes |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.