Repository navigation
fix: send an explicit null in a PATCH of an item - #6
Merged
Merged
Conversation
The client was generated with openApiNullable=false and the mapper drops nulls, so a nullable field of ItemUpdateRequest could not be cleared (packageSizeId, measurements, places, categoryId, sizeId, state). Generate with JsonNullable. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ItemUpdateRequestcould not be cleared.ApiClientsetsNON_NULLand the models were generated withopenApiNullable=false, sosetPackageSizeId(null)dropped the key from the PATCH and the API kept the old value (the documented way to clearpackageSizeId, measurements, places,categoryId,sizeId,state). A functional defect, not a generator quirk to accept.scripts/generate.shnow generates withopenApiNullable=true(JsonNullable wrappers); the generated code is regenerated from the same spec (.spec-sha256unchanged) andjackson-databind-nullableis added to the pom. The fluent setters keep theirLong/Stringsignatures:.packageSizeId(null)sendsnull, an unset field is omitted.Validation
mvn testgreen (23 tests). Nothing published to a registry.🤖 Generated with Claude Code