Repository navigation
feat(ffi): return delegated credentials to hosts that opt in - #193
Merged
Merged
Conversation
Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Out-of-process hosts (Go, C) can run
delegate()but never receive the token it mints:raw_credentialsis skip-serialized, so a host can only forward the caller's own bearer or fail.Changes
This adds an opt-in that returns minted credentials on allowed results:
cpex_apl_installflagCPEX_APL_EXPOSE_DELEGATED_CREDENTIALS(2).WithDelegatedCredentials(); results carryPipelineResult.DelegatedCredentials(header, value with scheme prefix, delegator, target, audience, scopes, expiry).SecretValuethat prints, marshals and logs as[REDACTED];Reveal()returns the token. RustDebugredacts too.ErrCpexInvalidInputinstead of silently returning nothing.Not covered: Python bindings.
Tests
Tests: FFI unit tests for the flag and redaction; the Go acceptance test asserts no credential without the opt-in, one
Authorization: Bearer <minted>with it, and none on deny. Verified end to end from cortex against a local build.