Repository navigation
Fix CF icon flicker on Servers page via targeted single-server patch - #194
Merged
vishu-bh merged 1 commit intoOct 21, 2026
Conversation
marekdano
approved these changes
Oct 20, 2026
marekdano
left a comment
Contributor
There was a problem hiding this comment.
@CloudCorpRecords - thanks for your contribution!
The core fix directly solves the issue and follows existing patterns in the codebase.
LGTM 🚀
Activate/deactivate and the Refresh action called refetch() after their API calls, which sets the page-level isLoading flag and remounts the whole ServersTable behind a spinner. This applies the same targeted-patch approach Tools.tsx uses in handleToggleTool: after the mutation, re-read just the affected server (with the single-server request cache invalidated first) and patch it into local state and the query cache. The table never unmounts, so there is no spinner and no flicker. Signed-off-by: Rene Turcios <95189389+CloudCorpRecords@users.noreply.github.com>
CloudCorpRecords
force-pushed
the
fix/servers-flicker-targeted-patch
branch
from
October 20, 2026 21:27
62ac3e4 to
019f204
Compare
vishu-bh
approved these changes
Oct 21, 2026
vishu-bh
left a comment
Contributor
There was a problem hiding this comment.
Clean implementation and solid code.
LGTM 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120.
Activate/deactivate and the Refresh action called refetch() after their API calls. That sets the page-level isLoading flag, which unmounts the whole ServersTable behind a spinner and reads as flicker.
This applies the same targeted-patch approach Tools.tsx uses in handleToggleTool: after the mutation the page re-reads just the affected server (serversApi.get, with the single-server request cache invalidated first) and patches it into local state and the query cache. The table never unmounts, so there is no spinner and no flicker.
Changes:
Tests: