Repository navigation
fix(gateways): hide source selector for single-source virtual servers - #192
Merged
Merged
Conversation
The virtual server details panel showed the "All sources | <server>" tabs even when every component came from one MCP server, where the selector offers nothing to choose between. Render it only when there is more than one source. The tab row no longer appears while sources are still loading, which avoids a flash of tabs on single-source servers. Adds Vitest coverage for the single-source case and a Playwright test for filtering components by source when there are several. Signed-off-by: Marek Dano <mk.dano@gmail.com>
vishu-bh
approved these changes
Oct 15, 2026
vishu-bh
left a comment
vishu-bh
left a comment
Contributor
There was a problem hiding this comment.
solid implementation and specific files changed
a-effort
approved these changes
Oct 20, 2026
a-effort
left a comment
a-effort
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
#195 adds the second half of IBM/mcp-context-forge#6445
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes IBM/mcp-context-forge#6445
Summary
The virtual server details panel showed the "All sources | " tab row even when every component came from a single MCP server, where it offers nothing to choose between. The selector now renders only when the server has more than one source. With several sources it keeps the existing tab style.
Changes
VirtualServerDetailsPanel.tsx: render the source tabs only whensourceTabs.length > 1; drop the now-unusedsourcesLoadingflag.VirtualServerDetailsPanel.test.tsx: add a Vitest case asserting no selector for a single source.e2e/virtual-servers.spec.ts: add a Playwright case for filtering components by source when there are several.Behaviour notes
One source
Multiple sources
