Skip to content

ci: note that cached build steps can hide download proxy hosts - #7693

Merged
viceice merged 1 commit into
mainfrom
viceice/ci/proxy-hosts-note
Oct 9, 2026
Merged

viceice merged 1 commit into
mainfrom
viceice/ci/proxy-hosts-note

Conversation

@viceice

@viceice viceice commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Changes

Adds a note above the "Download proxy hosts" table in the job summary and log: it only lists the requests the proxy saw in that job, so hosts of build steps reused from the cache can be missing. Follow-up to #7670.

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Claude Opus 5.5 (Claude Code) wrote the note from a review finding on #7670 and ran the local proxy test.

Use of AI in replying to PR comments

Who answers review comments:

  • @viceice will read and reply directly. Name the account.
  • An agent will draft replies and @username will read them before they are posted. Name the account.
  • An agent will draft replies and reply autonomously. This is heavily discouraged, and we prefer that there are humans in the loop
  • Nobody has explicitly committed to replying.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified tests

Ran .github/actions/download-proxy/test.sh locally, the note shows above the host table.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified that download proxy host counts reflect requests observed during the job; hosts may be absent when cached downloads bypass the proxy.

Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Clarify why cached builds may be absent from download proxy hosts

✨ Enhancement 🕐 Less than 5 minutes

Grey Divider

AI Description

• Add a note above the download proxy host table in CI logs and job summaries.
• Clarify that cached build steps make no requests, so their hosts may be absent.
Diagram

graph TD
  A["Build steps"] -->|downloads| B["Download proxy"] --> C["Access log"] --> D["Stats script"] --> E["Job summary"]
  A -->|reused steps| F["Build cache"]
  D --> G["Job log"]
Loading
High-Level Assessment

Keep the caveat immediately above the generated host table. This explains the limitation in both the job log and summary without changing proxy behavior or duplicating guidance elsewhere.

Files changed (1) +2 / -0

Enhancement (1) +2 / -0
stats.shExplain missing hosts in proxy statistics +2/-0

Explain missing hosts in proxy statistics

• Adds a note above the download proxy hosts table explaining that it includes only requests observed in the current job. Because cached build steps make no download requests, their hosts may be missing from the table.

.github/actions/download-proxy/stats.sh

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: containerbase/coderabbit/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fb2b01ad-b684-40f7-b56d-536aae02154a

📥 Commits

Reviewing files that changed from the base of the PR and between d1a4211 and 9164910.


📒 Files selected for processing (1)
  • .github/actions/download-proxy/stats.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

The download proxy statistics output now notes that host counts include only requests observed by the proxy during the job. It also notes that cached downloads may cause some hosts to be absent.

Changes

Download proxy statistics

Layer / File(s) Summary
Clarify proxy host counts
.github/actions/download-proxy/stats.sh
The output notes that counts cover requests observed during the job. Hosts may be absent when build steps reuse cached downloads.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other


Merge Risk: ⚪ Minimal · up to 91649

This change clarifies what the proxy host counts represent. No actionable merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: documenting that cached build steps can hide download proxy hosts.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@viceice
viceice added this pull request to the merge queue Oct 9, 2026
Merged via the queue into main with commit 2722242 Oct 9, 2026
59 of 61 checks passed
@viceice
viceice deleted the viceice/ci/proxy-hosts-note branch October 9, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant