Skip to content

fix: allow digits in the versioning of regex managers - #4162

Merged
viceice merged 1 commit into
mainfrom
viceice/fix/versioning-digits
Oct 8, 2026
Merged

viceice merged 1 commit into
mainfrom
viceice/fix/versioning-digits

Conversation

@viceice

@viceice viceice commented Oct 8, 2026

Copy link
Copy Markdown
Member

Changes

Allows digits in the versioning= value of the regex managers for _VERSION lines in Dockerfiles, install-* lines in Dockerfiles, and shell and .bats scripts, so versionings like pep440 match. Before, such a value didn't match the versioning group and ended up in depName, for example poetry versioning=pep440, which failed the lookup. The GitHub workflow managers already accept any value.

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Claude Opus 5.5 (Claude Code) traced the failed lookup to the regex and wrote the change.

Use of AI in replying to PR comments

Who answers review comments:

  • @viceice will read and reply directly. Name the account.
  • An agent will draft replies and @username will read them before they are posted. Name the account.
  • An agent will draft replies and reply autonomously. This is heavily discouraged, and we prefer that there are humans in the loop
  • Nobody has explicitly committed to replying.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified tests

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>
@viceice
viceice enabled auto-merge (squash) October 8, 2026 16:24
@viceice
viceice merged commit 4fa906c into main Oct 8, 2026
7 checks passed
@viceice
viceice deleted the viceice/fix/versioning-digits branch October 8, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant