Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions packages/deparser/__tests__/misc/bit-string.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import { Deparser } from '../../src';
import { expectParseDeparse } from '../../test-utils';

const payload = "x' OR '1'='1";

const selectConst = (aConst: any) => ({
SelectStmt: {
targetList: [{ ResTarget: { val: { A_Const: aConst } } }],
limitOption: 'LIMIT_OPTION_DEFAULT',
op: 'SETOP_NONE'
}
});

describe('bit-string literals', () => {
it('round-trips binary and hex bit strings', async () => {
await expectParseDeparse(`SELECT B'1010', X'1F'`);
});

it.each([
['b-prefixed', { bsval: { bsval: `b${payload}` } }, `SELECT b'x'' OR ''1''=''1'`],
['x-prefixed', { bsval: { bsval: `x1F' OR '1'='1` } }, `SELECT b'x1F'' OR ''1''=''1'`],
['unprefixed', { bsval: { bsval: `1' OR '1'='1` } }, `SELECT b'1'' OR ''1''=''1'`],
['unwrapped', { bsval: `b${payload}` }, `SELECT b'x'' OR ''1''=''1'`],
['val.BitString', { val: { BitString: { bsval: `b${payload}` } } }, `SELECT b'x'' OR ''1''=''1'`]
])('escapes single quotes in %s A_Const bsval', (_label, aConst, expected) => {
expect(Deparser.deparse(selectConst(aConst) as any)).toBe(expected);
});

it('escapes single quotes in BitString nodes', () => {
const deparser = new Deparser([]);
expect(deparser.BitString({ bsval: `b${payload}` }, {} as any)).toBe(`b'x'' OR ''1''=''1'`);
});
});
43 changes: 15 additions & 28 deletions packages/deparser/src/deparser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,17 @@ function isWrappedParseResult(obj: any): obj is { ParseResult: t.ParseResult } {
* The deparser automatically detects bare ParseResult objects for backward
* compatibility and wraps them internally for consistent processing.
*/
function formatBitString(bsval: string): string {
const quote = (value: string) => value.replace(/'/g, "''");
if (/^x[0-9A-Fa-f]+$/.test(bsval)) {
return `x'${bsval.substring(1)}'`;
}
if (bsval.startsWith('b')) {
return `b'${quote(bsval.substring(1))}'`;
}
return `b'${quote(bsval)}'`;
}

export class Deparser implements DeparserVisitor {
private tree: Node[];
private options: DeparserOptions;
Expand Down Expand Up @@ -1812,15 +1823,7 @@ export class Deparser implements DeparserVisitor {
} else if (nodeAny.bsval !== undefined) {
if (typeof nodeAny.bsval === 'object' && nodeAny.bsval !== null) {
if (nodeAny.bsval.bsval !== undefined) {
const bsval = nodeAny.bsval.bsval;
// Check if this is a hexadecimal bit string (starts with x and contains only hex digits)
if (bsval.startsWith('x') && /^x[0-9A-Fa-f]+$/.test(bsval)) {
return `x'${bsval.substring(1)}'`;
}
if (bsval.startsWith('b')) {
return `b'${bsval.substring(1)}'`;
}
return `b'${bsval}'`;
return formatBitString(nodeAny.bsval.bsval);
} else if (Object.keys(nodeAny.bsval).length === 0) {
return "''";
} else {
Expand All @@ -1829,15 +1832,7 @@ export class Deparser implements DeparserVisitor {
} else if (nodeAny.bsval === null) {
return 'NULL';
} else {
const bsval = nodeAny.bsval;
// Check if this is a hexadecimal bit string (starts with x and contains only hex digits)
if (bsval.startsWith('x') && /^x[0-9A-Fa-f]+$/.test(bsval)) {
return `x'${bsval.substring(1)}'`;
}
if (bsval.startsWith('b')) {
return `b'${bsval.substring(1)}'`;
}
return `b'${bsval}'`;
return formatBitString(nodeAny.bsval);
}
}

Expand All @@ -1851,7 +1846,7 @@ export class Deparser implements DeparserVisitor {
} else if (nodeAny.val.Boolean?.boolval !== undefined) {
return nodeAny.val.Boolean.boolval ? 'true' : 'false';
} else if (nodeAny.val.BitString?.bsval !== undefined) {
return nodeAny.val.BitString.bsval;
return formatBitString(nodeAny.val.BitString.bsval);
}
}

Expand Down Expand Up @@ -2615,15 +2610,7 @@ export class Deparser implements DeparserVisitor {
}

BitString(node: t.BitString, context: DeparserContext): string {
// Check if this is a hexadecimal bit string (starts with x)
if (node.bsval.startsWith('x')) {
return `x'${node.bsval.substring(1)}'`;
}
if (node.bsval.startsWith('b')) {
return `b'${node.bsval.substring(1)}'`;
}
// Fallback for raw values without prefix
return `b'${node.bsval}'`;
return formatBitString(node.bsval);
}

Null(node: t.Node, context: DeparserContext): string {
Expand Down
Loading