Repository navigation
feat(errors): register the platform billing error codes - #1865
Merged
Merged
Conversation
…TIVE, BILLING_QUOTA_EXCEEDED) Re-audited constructive-db feat/platform-billing-generic (69a1913ffc8) and regenerated the registry; curated public copy for the deletion guard's BILLING_SUBSCRIPTION_ACTIVE (409) and the usage gate's BILLING_QUOTA_EXCEEDED (429). The same audit adds the internal BILLING_CHECKOUT_BINDING_INVALID, BOOTSTRAP_OWNER_NOT_ACTIVE and SCHEDULED_JOB_NOT_ENQUEUED, and drops FREE_PLAN_REQUIRED, which the billing branch no longer raises.
|
Review complete. No issues found — approved ✅. This PR extends the shared error registry with two billing-related codes:
Reviewed commit: fc65ee6 |
…ory and registry against constructive-db#3904
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorEnvelopeand the gateway return their proper HTTP status instead of treating them as unknown.scripts/audit-db-errors.py. The public entries are curated insrc/registry.ts.Codes
BILLING_SUBSCRIPTION_ACTIVE{ entity_id, external_subscription_id }BILLING_QUOTA_EXCEEDEDBILLING_CHECKOUT_BINDING_INVALID{ entity_id, operation_id }bind_checkout_session, a system-only seam, called with a null id (a caller bug)BOOTSTRAP_OWNER_NOT_ACTIVE,SCHEDULED_JOB_NOT_ENQUEUEDFREE_PLAN_REQUIREDis dropped, because the rework no longer raises it.Merge order
Merge after constructive-io/constructive-db#3904. Before merging, re-run
scripts/audit-db-errors.pyagainst the merged db main: this snapshot was taken from the db branch, so newer db-main codes may be missing.🤖 Generated with Claude Code
https://claude.ai/code/session_01BqoF2inmLL6xPNjX1JiqXx