Repository navigation
feat(ui): generalize billing provider descriptors and payment method display - #48
Merged
Merged
Conversation
…display - Add logo, merchantOfRecord, immutablePrices, modeLabels, and detectMode to BillingProviderDescriptor so non-Stripe providers describe their own behaviour instead of inheriting Stripe assumptions - Show the payment method on file through a provider-neutral PaymentMethodSummary and PaymentMethodRow, with expiry warnings - Keep provider object ids and dashboard links out of customer views - Name modes and the test-mode feature the provider's way in the console
|
Review complete. No blocking issues — approved ✅; 1 nitpick below. 🧹 Nitpicks (1) — 🟢 1 low
The change reworks how billing providers describe themselves and how payment methods render to customers. Provider descriptors gain explicit mode-detection and label fallbacks, and the console's connect flow now calls
Reviewed commit: c0d2387 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the billing templates provider-neutral in shape, not just in name, and stops showing provider internals to customers.
BillingProviderDescriptor(all optional, so existing descriptors keep working):logo: an image drawn on the provider tile instead of the monogrammerchantOfRecord: the payment panel says the provider charges, handles tax, and issues invoicesimmutablePrices: the catalog copy about immutable prices only appears for providers that work that waymodeLabels: e.g. Sandbox instead of Test, used by the console badge, sidebar, provider card, and feature chipdetectMode: replaces running Stripe's key-prefix parsing on every provider's credentialssub_…id and the merchant-dashboard link, which customers couldn't open, and shows the method on file through a new provider-neutralpaymentMethodfield rendered byPaymentMethodRow(card brand, last four, expiry with "Expires soon" / expired states; wallets, bank accounts, invoicing).🤖 Generated with Claude Code
https://claude.ai/code/session_01GPTLDuvMBGBawVLKL42yYV