Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a PTY session while a keystroke-padding packet is in flight can let a
TransportExceptionescape the chaff coroutine and terminate the client process. We observed Android crashes withConnection closed: Socket closedandPacket writer stoppedduring tab shutdown. An admitted write can report a transport failure even after its coroutine has been cancelled.Route these failures through the existing
transportFailedpath, consistent with the delivery workers fixed in #314. This closes unexpected failures normally and ignores connections already shutting down. Preserve ordinaryCancellationExceptionpropagation and keep keystroke padding enabled.Adds three deterministic regressions covering a failed chaff write, a write that fails after cancellation, and normal cancellation. The first two fail without the fix.
Validation: all 86 tests across
KeystrokeObfuscationTest,SessionChannelTest,ForwardingChannelTest,ConnectionBackpressureTest, andPacketWriterTestpass.spotlessCheckand:sshlib:metalavaCheckCompatibilityalso pass.