Skip to content

feat: say why download_gpg_key failed - #208

Merged
MickLesk merged 4 commits into
mainfrom
fix/gpg-key-failure-reason
Nov 4, 2026
Merged

MickLesk merged 4 commits into
mainfrom
fix/gpg-key-failure-reason

Conversation

@MickLesk

@MickLesk MickLesk commented Nov 4, 2026

Copy link
Copy Markdown
Member

✍️ Description

download_gpg_key returned 7 whether the download or gpg --dearmor failed, and dropped curl's and gpg's messages, so its callers could only say that the key failed. 14 Frigate runs on 9 hosts in three days stopped at the Intel graphics key with nothing more, and the NodeSource, pgdg and Jellyfin key failures look the same. After the last attempt it now warns with the error of that attempt.

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

download_gpg_key returned 7 whether the download or gpg --dearmor
failed, and dropped curl's and gpg's messages, so its callers could only
say that the key failed. 14 Frigate runs on 9 hosts in three days stopped
at the Intel graphics key with nothing more, and the NodeSource, pgdg and
Jellyfin key failures look the same. After the last attempt it now warns
with the error of that attempt.
…eason

# Conflicts:
#	.github/workflows/verify-split-files.yml
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/gpg-key-failure-reason \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/gpg-key-failure-reason/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/fix/gpg-key-failure-reason

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

…eason

# Conflicts:
#	.github/workflows/verify-split-files.yml
@MickLesk
MickLesk merged commit 2867a75 into main Nov 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant