Skip to content

feat: read the MOTD's OS version at login - #207

Merged
MickLesk merged 2 commits into
mainfrom
fix/motd-os-version-at-login
Nov 4, 2026
Merged

MickLesk merged 2 commits into
mainfrom
fix/motd-os-version-at-login

Conversation

@MickLesk

@MickLesk MickLesk commented Nov 4, 2026

Copy link
Copy Markdown
Member

✍️ Description

motd_ssh wrote the release into the login banner and /etc/motd as fixed text, so a container upgraded in place kept showing the release it was created with (ProxmoxVE#18451). The profile.d line now reads /etc/os-release at login, and /etc/motd no longer carries the version. update_motd_ip turns an old fixed line into the new one and runs from on_exit, since most ct scripts exit inside update_script and never reached it.

🔗 Related Issue

Fixes #206

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

motd_ssh wrote the release into the login banner and /etc/motd as fixed text, so a container upgraded in place kept showing the release it was created with (ProxmoxVE#18451). The profile.d line now reads /etc/os-release at login, and /etc/motd no longer carries the version. update_motd_ip turns an old fixed line into the new one and runs from on_exit, since most ct scripts exit inside update_script and never reached it.
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/motd-os-version-at-login \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/motd-os-version-at-login/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/fix/motd-os-version-at-login

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

…t-login

# Conflicts:
#	.github/workflows/verify-split-files.yml
@MickLesk
MickLesk merged commit 168e80a into main Nov 4, 2026
4 checks passed
@github-actions
github-actions Bot deleted the fix/motd-os-version-at-login branch November 5, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Motd when login should not have distro version hard-coded

1 participant