Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_inlinestrips trailing whitespace from a text run that ends at a line ending withcmark_chunk_rtrim, which also removes tabs. The spec removes only trailing spaces at the end of a line before a soft or hard line break, so a trailing tab should survive:foo\t\nbarrenders as<p>foo\nbar</p>here but<p>foo\t\nbar</p>in commonmark.js 0.31.2 and per the spec (section "Soft line breaks": "Spaces at the end of the line ... are removed"). Strip only trailing spaces at that site; the paragraph-final trim and the ATX trailing-hashtag trim, which the spec does strip tabs from, are left alone.This fix was found and prepared with AI assistance and reviewed by me before submitting.