Repository navigation
fix prefix truncation after empty list items in commonmark renderer - #638
Merged
Merged
Conversation
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S_render_node pops marker_width characters from the indentation prefix on every CMARK_NODE_ITEM exit, but the matching push on enter only happens when the item has children, since an empty item takes the BLANKLINE branch instead. An empty item inside a block quote therefore truncates the enclosing "> " prefix, so everything rendered after it escapes the quote:
> - a,> -,> - bemits the last item unquoted and the output no longer round-trips. Truncate only when the spaces were actually pushed, mirroring the enter side, with a regression case in the render_commonmark api test.