Repository navigation
fix latex enumerate counter level inside bullet lists - #636
Merged
Merged
Conversation
Member
|
great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrong enumerate counter level for ordered lists nested in bullet lists
S_get_enumlevelwalks the ancestor chain but testscmark_node_get_list_type(node)(the starting node) on every iteration instead oftmp, the ancestor it is actually looking at. When the ordered list sits inside a bullet list, the enclosingitemizelevels get counted too, so a list withstart> 1 emits\setcounter{enumii}rather than\setcounter{enumi}and the counter it sets is not the one LaTeX uses, leaving the list numbered from 1.The fix queries the type of
tmpso only ordered-list ancestors raise the level. Added an api_test that parses- outer/5. fiveand checks the LaTeX output usesenumi; worth confirming the expected string matches on your end.