Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds RFC 8058 one-click unsubscribe headers to every marketing send (broadcasts and sequences share
automation/process-ongoing-sequence.ts).apps/api/src/utils/mail.ts: newgetListUnsubscribeHeaders(unsubscribeToken)returnsList-Unsubscribe: <https://…/unsubscribe/:token>andList-Unsubscribe-Post: List-Unsubscribe=One-Click. It reuses the existing per-contact unsubscribe token and URL from Fix tracking link paths, confirm unsubscribes, require SUPPRESSION_HASH_KEY for self-host #43, so there is no new signing scheme.apps/api/src/automation/process-ongoing-sequence.ts: passes these headers tosendMail.sendMailforwardsheadersto the team's nodemailer SMTP transport, which every ESP preset uses (SMTP/SES/SendGrid/Mailgun/Postmark/Resend). No adapter drops them.mailto:entry: there is no configured unsubscribe mailbox to receive one. The https one-click URL is what Gmail/Yahoo require.Tests
process-ongoing-sequence.test.ts: checks that both headers are on the sent mail.tracking/routes.test.ts: new test POSTsList-Unsubscribe=One-Clickto/unsubscribe/:token, then checks for a 200 with no confirmation page and that the contact is unsubscribed.Results
pnpm --filter @sendlit/api test: 75 files / 429 tests passedpnpm --filter @sendlit/api typecheck: cleanpnpm lint: cleanCloses #23