Repository navigation
Take the shared modules from notebook-language-server-core - #8
Merged
Merged
Conversation
thomasjm
force-pushed
the
use-core
branch
3 times, most recently
from
October 12, 2026 03:30
23864cf to
66c5670
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the 14 modules cpp shared verbatim with rust and go (the Transformer class, all the Transform modules, Parsing, Process, RequestMap) in favour of the core library, and adds
cppNotebookConfigfor the parts that are cpp's own: the.cppsibling shadow document and theclangd/analyzerStatuscustom method.Two behaviour changes fall out: textDocument/formatting responses now get untransformed (core handles it), and closing a never-opened notebook no longer appends
.rs.Stacked on #7.