Repository navigation
Pick up the core fix that transforms codeLens/resolve - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up codedownio/notebook-language-server-core@cb55077, which transforms
codeLens/resolve. A resolve request carries no text document, so the notebook uri now rides in the lens'sdata: code lens responses stamp it, resolve requests unstamp it to find the document and map the range into shadow coordinates, and the response maps back. Without it the resolve reached the server with the lens's notebook range and either found nothing or resolved against the wrong binding.Pin bump only; the logic and its tests are in core.