Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers parts 1 and 2 of #120 end to end, via
getAndResolveCodeLenses— the same path codedown uses.x :: Integerresolves onto notebook line 1 andfoo :: IO ()onto line 3.expr…title.Verified against a locally built hnls carrying both fixes: both tests pass. Against an hnls without the
codeLens/resolvetransform they fail withghcide-type-lenses: Stale Resolve, which is the symptom in the issue — so this does discriminate.Do not merge until hnls is released with the fix and
hnls-version.nixis bumped. The released binary doesn't have it yet, so this will fail on main until then.