Repository navigation
chore(deps): bump sprockets from 4.2.2 to 4.4.1 - #3053
Merged
Merged
Conversation
Sprockets 4.2.2 calls JSON.parse with a create_additions option, which json 3.x rejects as an unknown keyword, so the app fails to boot once json 3 is in the lock. Sprockets 4.3.0 added json 3 compatibility (rails/sprockets#829); 4.4.0 and 4.4.1 add the ignore_mtime option and a cache-limit opt-out. Unblocks the dependabot json bump in #3051: merge this first, then rebase #3051.
mroderick
marked this pull request as ready for review
October 22, 2026 14:41
olleolleolle
approved these changes
Oct 22, 2026
olleolleolle
left a comment
olleolleolle
left a comment
Collaborator
There was a problem hiding this comment.
Thanking them for keeping it up-to-date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps sprockets 4.2.2 → 4.4.1. This is the second prerequisite for the json 3.x bump in #3051: sprockets 4.2.2 passes
create_additions:toJSON.parse, which json 3.x rejects as an unknown keyword, so the app fails to boot as soon as json 3 enters the lock. Sprockets 4.3.0 fixed json 3 compatibility (rails/sprockets#829).Gemfile.lockonly, three lines. json stays at 2.21.2 here.ignore_mtimeoption and a cache-limit opt-out; the changelog has no breaking changes, and runtime dependencies are unchanged.@dependabot rebaseon chore(deps): bump json from 2.21.2 to 3.1.0 #3051. The other way round leaves master unable to boot.Review notes
jsonpin comment in theGemfilebelongs to that PR.