You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Extract organiser grant/revoke diffing from Admin::WorkshopsController #2941
Admin::WorkshopsController mutates Member roles directly from private controller methods, on both create (assign_organisers_or_default) and update (update_workshop_details):
Diffing desired vs current organisers and mutating roles is application-layer orchestration, not HTTP coordination.
Proposed change
Extract the diff + grant/revoke into a service object under app/services/ (follow the existing *_service conventions there; naming up to the implementer).
The controller calls it from create/update; the default-to-chapter-organisers branch moves with it.
Acceptance
Admin::WorkshopsController no longer contains role-diffing logic.
Organiser membership changes identically after create/update, including the default-to-chapter-organisers path.
Activity
Add service and controller specs for organiser assignment (codebar#2941)
davidmillen50 commentedon Oct 19, 2026
WIP #3049
chore: add update revocation controller spec (codebar#2941)
chore: rubocop fix for service spec (codebar#2941)
chore: remove stray MACOS_PUMA_FORK_FIX.txt (codebar#2941)
chore: fix empty-string organiser filter and correct default branch (c…
chore: fix empty-string organiser filter and correct default branch (c…
Simplify WorkshopOrganiserAssigner and remove redundant chapter arg
chore: simplifiy WorkshopOrganiserAssigner, remove redundant chapter …