Repository navigation
Modernize the project: Go 1.27, e2e tests, and bug fixes - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch updates the project to Go 1.27, replaces the manual e2e test with automated e2e tests, and fixes the bugs that the new tests found.
Toolchain and CI
pflagandviper-litereplaced withgo-flags. The names of the flags and the environment variables do not change.--helpshows the environment variables.CGO_ENABLED=0). Thelinux/amd64binary of 1.0.2 needed glibc and did not start on Alpine images.E2E tests
The tests start the wrapper with php-fpm in a container (testcontainers-go) as
www-data. CI runs them onphp:5.6,7.4,8.2,8.3,8.4,8.5(Alpine) and8.5(Debian). Run them locally withmake e2e.Fixes
--shutdown-delayalso applies to SIGQUIT. The php-fpm images haveSTOPSIGNAL SIGQUIT, so Docker and Kubernetes stopped php-fpm without the delay.decorate_workers_output = no, the default of the official images).0666for all umask values. Before, workers that run as a different user than the master could not write to it.php-fpm -ttand runs php-fpm with an overlay config in--run-dir. The overlay moveserror_logand the slowlogs to FIFOs. This fixes these problems:error_log = /proc/self/fd/2in an included file) was not proxied;include(PHP 7.4 and earlier images) was not found;error_login/var/log;--log-encodercaused a panic.New features
--session-cleanup-intervalremoves expired PHP session files, as thesessioncleancron job of Debian does. It is off by default.--run-dirsets the directory for the generated php-fpm config and the log FIFOs.Behavior changes
See
CHANGELOG.md, section "Unreleased". The most important:error_log = syslogalso goes through the proxy. Use--fpm-no-errlogto keep it.WRAPPER_PIPE=.--that is not a flag of the wrapper stops the wrapper at start.--log-levelaccepts a name or a number from-1to5.