Repository navigation
Rerun Submission - Allow admins to rerun submissions in any status - #2613
Merged
Merged
Conversation
ObadaS
self-requested a review
October 6, 2026 13:38
2 of 4 tasks
…eruns - Remove the status check from the re_run_submission endpoint so that competition organizers and superusers can rerun a submission in any status, not only Finished, Failed or Cancelled - Return 403 when rerunning a soft-deleted submission - Add SubmissionReRunTests
ObadaS
force-pushed
the
rerun-submission-any-status
branch
from
October 13, 2026 08:43
0e40ec0 to
edf6cfe
Compare
Collaborator
|
I tried to re-run all submission (including a soft deleted one) and it worked without any errors, however it also re-ran the soft deleted submission Soft deleted file : Re-run result : |
Collaborator
Author
|
This problem was already there and is not created by the updates in this PR so I will note this down in an issue and fix it in a separate PR. Note: This PR only fixes the rerun for a single submission rerun. The problem Obada reported comes from running multiple submissions or the complete phase submissions |
ObadaS
approved these changes
Oct 13, 2026
| started_task_pks = sorted(task.pk for task in run_submission_mock.call_args.kwargs['tasks']) | ||
| assert started_task_pks == sorted(task.pk for task in tasks) | ||
|
|
||
| def test_cannot_re_run_soft_deleted_submission(self): |
Collaborator
There was a problem hiding this comment.
Somehow, I was able to re-run a soft deleted submission on the frontend. Shouldn't this test fail since this is possible currently ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues this PR resolves
Checklist