Repository navigation
Set TraitsUpdated when the recorded traits match the spec - #377
Merged
Merged
Conversation
fwiesel
force-pushed
the
traits-handover-fix
branch
from
October 30, 2026 13:58
01c702a to
fb25866
Compare
fwiesel
force-pushed
the
traits-handover-fix
branch
from
October 30, 2026 14:08
fb25866 to
cb252b0
Compare
fwiesel
force-pushed
the
traits-handover-fix
branch
from
October 30, 2026 14:16
cb252b0 to
d0c5c3b
Compare
fwiesel
force-pushed
the
traits-handover-fix
branch
2 times, most recently
from
October 30, 2026 14:46
c4d9098 to
ea27890
Compare
The reconcile returned early when the desired and the recorded custom traits matched, without ever setting TraitsUpdated. That condition gates the handover phase, so hypervisors without custom traits could never finish onboarding. Report success from the recorded state in that case. Placement is only queried when the spec and the recorded traits diverge, as before, and the comparison is now order-insensitive. While such a sync runs, the applied set is read from placement instead of the status cache, so stray custom traits are removed in a single pass. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
fwiesel
force-pushed
the
traits-handover-fix
branch
from
October 30, 2026 14:52
ea27890 to
0dc7aa4
Compare
fwiesel
marked this pull request as ready for review
October 30, 2026 14:52
|
Caution No coverage for base commit eef6ad6 was found, so this report compares against its ancestor 8f1100d (1 commit earlier) Merging this branch will increase overall coverage
Coverage detailsCompared to commit 8f1100d (run #40940906890)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files:
|
mchristianl
approved these changes
Oct 30, 2026
notandy
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the desired and the recorded custom traits matched, the traits controller returned early without ever setting
TraitsUpdated— and that condition gates the handover phase, so hypervisors without custom traits could never finish onboarding.Adds specs for the no-custom-traits and already-matching cases.