Repository navigation
Conversation
…ter_external_customer errors on failover validation Signed-off-by: Marcel <156897072+mblos@users.noreply.github.com>
mblos
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer and
umswmayj
as code owners
October 26, 2026 10:08
Contributor
Missing intent exemption in
|
Signed-off-by: Marcel <156897072+mblos@users.noreply.github.com>
Contributor
Test Coverage ReportTest Coverage 📊: 71.4% |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failover reservation controller's validation call used EvacuateIntent to make filter_has_enough_capacity unlock reservation resources for the VM being validated. The validation checks whether a reservation slot is still valid for its intended VMs.
However, EvacuateIntent is also used by real Nova evacuate requests, which carry a domain_name scheduler hint. The cortex-internal validation call does not (no user-domain context). This caused filter_external_customer to log errors on every failover validation, and filter_quota_enforcement to potentially reject valid reservation hosts for over-quota projects, silently breaking failover.
This PR introduces ValidateFailoverReservationIntent alongside the other cortex-internal intents, so both filters skip correctly for the validation call.