Repository navigation
squid: revert nvmeof workaround and introduce new container image - #42
Merged
Merged
Conversation
…#39)" This reverts commit 6a1ca82, reversing changes made to f973198. The workaround handed nvmeof gateways a key of the older aes type, because every squid-line gateway image bundled a librados from before aes256k and could not authenticate with the aes256k keys cephadm creates since 19.2.6. While the workaround was being worked on, ceph-nvmeof published 1.4.29, the first squid-line image built on a ceph that knows aes256k (19.2.7): https://github.com/ceph/ceph-nvmeof/releases/tag/1.4.29 ceph/ceph-nvmeof#2230 The gateways can use the key cephadm already gives them, so revert the workaround and move the default image to 1.4.29 instead. Ref: https://tracker.ceph.com/issues/81778 Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com> On-behalf-of: SAP <t.dehler@sap.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
quay.io/ceph/nvmeof:1.2.5 bundles a librados built from ceph 19.0.0,
which predates the aes256k cephx key type. Since cephadm creates
aes256k daemon keys (19.2.6 on), that gateway cannot connect at all:
ERROR state.py:357: Unable to create OMAP, exiting!
rados.IOError: [errno 5] RADOS I/O error (error connecting to the
cluster)
nvmeof:1.4.29 is the first image of the squid line built on a ceph that
knows aes256k (19.2.7), so it can use the key cephadm gives it.
Bumped in all three places that name the image: the mgr module, the
cephadm binary constants (still on 1.2.1) and the example listing in
the monitoring docs.
Also update the nvmeof conf template. Say why bdevs_per_cluster has to
stay. Under nvmeof 1.2.5 this was an ordinary tunable. 1.4.x picks its
cluster allocator from whichever of bdevs_per_cluster,
flat_bdevs_per_cluster or cluster_connections is set. In that order.
The template emits only the first. Removing it as redundant would leave
the gateway without an allocator, and it exits at startup with
"Unknown cluster allocator in the config". Add a jinja comment, so the
rendered ceph-nvmeof.conf is unchanged.
Ref: https://tracker.ceph.com/issues/81778
Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com>
On-behalf-of: SAP <t.dehler@sap.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Tatjana Dehler <tatjana.dehler@clyso.com> On-behalf-of: SAP <t.dehler@sap.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes cobaltcore-dev/cloud-storage#625
Backport file
release-management/backports/<uuid>.mdadded (or updated) by this PRidin frontmatter matches the filename stemprovenance.upstream_prsset (orprovenance.type: otherwith another:block)Stage-B risk (filled per
release-management/backports/RISK-RUBRIC.md)blast— cosmetic / availability / data-lossconflict— clean / trivial / substantivecoverage— strong / partial / weakhighband)Merge
Land this via
just merge-backport PR=<N>— do not click the green merge button.The just recipe constructs the merge commit's
Backport-Idtrailer.