Repository navigation
fix(web): stop restart waits after each test - #147
Merged
Merged
Conversation
A restart wait polls for up to 90 s on real timers. In tests it outlived its file, and a poll after jsdom tore down window failed the run with 'window is not defined' (seen once on PR #146, McpSection.test.tsx). A superseded wait now stops after its current poll, and the test setup ends every wait after each test.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #147 +/- ##
=======================================
Coverage 94.76% 94.76%
=======================================
Files 365 365
Lines 29302 29302
Branches 3748 3748
=======================================
Hits 27767 27767
Misses 1012 1012
Partials 523 523 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A restart wait (
useReloadAfterRestart) polls the server for up to 90 s on real timers. In tests it outlived its file. A poll that landed after jsdom closedwindowfailed the Frontend job withReferenceError: window is not defined(run 40889383420, attributed toMcpSection.test.tsx; all 2,137 tests had passed).waitForRestarttakes acurrentcheck and returns without another sleep once a later wait replaced it.stopRestartWaits()ends every running wait;src/test/setup.tscalls it after each test.Scores: likelihood 3 (one failure in recent runs) × impact 2 (a rerun) = 6.
Checks
npm run lint,npm run typecheck,npx vitest run: 172 files, 2,138 tests, no unhandled errors.Also checked here
This PR changes no dependency file and no
ci.yml, so it is the first ordinary PR since ADR-107.Floor matrix scopeshould print[""]and only the baseFloor resolutionentry should run.Codecov
Codecov uploads from before 13:40 UTC today went to the old repository name
llamaindex-rag-mcpand stayed pending. Uploads since then go tocmdaltctr/omrsand complete. This PR's upload checks that again; no workflow change is needed if it completes.