Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Result-specific alert identities can delay detection when failure modes alternate and produce duplicate alerts when both persist.
1 open issue
What changed in this PR
Adds WebhookInjectorCertRotationStuck to monitor potential webhook-injector certificate rotation failures.
Changes:
- Detects sustained excessive requeues or reconciliation errors.
- Adds configurable alert settings, diagnostic annotations, and a playbook link.
| File | Description |
|---|---|
| charts/controlplane-operations/alerts/controlplane-remote.yaml | Adds the certificate rotation alert and its configuration. |
Review effort: Balanced
yahor-kurachkin
force-pushed
the
add-webhook-injector-cert-rotation-stuck-alert
branch
2 times, most recently
from
October 21, 2026 12:54
ef51e82 to
9440611
Compare
Signed-off-by: C5421281 <yahor.kurachkin@sap.com>
yahor-kurachkin
force-pushed
the
add-webhook-injector-cert-rotation-stuck-alert
branch
from
October 21, 2026 12:56
9440611 to
1ba31ec
Compare
valeryia-hurynovich
approved these changes
Oct 22, 2026
defo89
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

feat: Create WebhookInjectorCertRotationStuck alert
Summary
Adds monitoring for webhook-injector certificate rotation failures in
controlplane-operations.The alert detects sustained reconciliation issues — excessive requeues or persistent errors — in the
configmapcontroller running thewebhook-injectorcontainer.Alert Logic
Triggers when either condition persists over a 5-minute window:
Changes
charts/controlplane-operations/alerts/controlplane-remote.yaml— adds theWebhookInjectorCertRotationStuckalert rule with configurable thresholds, diagnostic annotations, and a playbook linkNotes