Update TypeScript to 6.0.3 - #2515
Merged
Merged
Conversation
@cloudfour/eslint-config v28 (via eslint-config-xo 2.0.0) peers typescript >=6, so on 5.9.3 npm installed an unused nested typescript@7.0.2 plus its 20 platform binaries. typescript-eslint caps TypeScript at <6.1.0, so 6.0.3 is the only line that satisfies both. The nested copy is dropped from the lockfile. Fixes #2465
|
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Closed
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This repo has been stuck on TypeScript 5.9.3, which no longer satisfies the lint stack.
@cloudfour/eslint-configv28 pulls ineslint-config-xo2.0.0, which requirestypescript >=6. To satisfy that, npm has been installing a second, unusedtypescript@7.0.2(plus 20 platform-specific binaries) inside the eslint config. At the same time,typescript-eslintonly supports TypeScript<6.1.0, so 6.0.3 is the only release that works with both.This bumps TypeScript to 6.0.3 and removes the nested 7.0.2 copy from the lockfile. The lint false positives that originally blocked TypeScript 6 (#2465) came from the older
typescript-eslint8.55.0 that eslint-config v25 pinned, and they no longer reproduce. No source or config changes were needed, and the builtdist/output is byte-identical to the 5.9.3 build.Screenshots
Testing
npm cinpm ls typescript --all— every entry should betypescript@6.0.3, with no7.0.2anywhere