Repository navigation
Conversation
kornelski
force-pushed
the
stdlib-dupes
branch
3 times, most recently
from
August 14, 2026 16:35
b0277e2 to
03672fc
Compare
cjpatton
approved these changes
Aug 14, 2026
kornelski
force-pushed
the
stdlib-dupes
branch
from
August 15, 2026 01:41
03672fc to
dd6696a
Compare
bwesterb
approved these changes
Aug 15, 2026
Lekensteyn
reviewed
Sep 30, 2026
| .merge_extern_blocks(true) | ||
| .prepend_enum_name(true) | ||
| .allowlist_item("[A-Z].*|.*_.*|tm.*|time.*") // Exclude unprefixed stdlib and POSIX functions | ||
| .blocklist_item("rusage.*|RLIMIT.*|USE_CLANG.*|__?v?snprintf.*|.*DEPRECATED.*|sig[a-z0-9]*_t|__sig.*|_?sigaction.*|__darwin_(arm_|[um]context).*|[um]context_t|__arm_.*|__AVAIL.*|MAC_OS_(X_)?VER.*") |
Collaborator
There was a problem hiding this comment.
Some more failures on Android due to signal-related symbols, https://github.com/cloudflare/boring/actions/runs/31857179845/job/94944070421?pr=520
error[E0425]: cannot find type `__sighandler_t` in this scope
--> /home/runner/work/boring/boring/.cache/build-dir/x86_64-linux-android/debug/build/boring-sys-95dbbaded2f700d3/out/bindings.rs:6719:21
|
6719 | pub sa_handler: __sighandler_t,
| ^^^^^^^^^^^^^^ not found in this scope
error[E0425]: cannot find type `__sigrestore_t` in this scope
--> /home/runner/work/boring/boring/.cache/build-dir/x86_64-linux-android/debug/build/boring-sys-95dbbaded2f700d3/out/bindings.rs:6721:22
|
6721 | pub sa_restorer: __sigrestore_t,
| ^^^^^^^^^^^^^^ not found in this scope
error[E0425]: cannot find type `sigset_t` in this scope
--> /home/runner/work/boring/boring/.cache/build-dir/x86_64-linux-android/debug/build/boring-sys-95dbbaded2f700d3/out/bindings.rs:6722:18
|
6722 | pub sa_mask: sigset_t,
| ^^^^^^^^ not found in this scope
error[E0425]: cannot find type `sigval_t` in this scope
--> /home/runner/work/boring/boring/.cache/build-dir/x86_64-linux-android/debug/build/boring-sys-95dbbaded2f700d3/out/bindings.rs:6827:18
|
6775 | pub union sigval {
| ---------------- similarly named union `sigval` defined here
...
6827 | pub _sigval: sigval_t,
| ^^^^^^^^
|
Aside from that there are also warnings, but these exist before this PR:
[boring-sys 5.2.0] android toolchain=/usr/local/lib/android/sdk/ndk/27.3.13750724/build/cmake/android.toolchain.cmake
[boring-sys 5.2.0] CMAKE_GENERATOR = None
[boring-sys 5.2.0] cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-android-clang": No such file or directory (os error 2)
[boring-sys 5.2.0] cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-android-clang++": No such file or directory (os error 2)
[boring-sys 5.2.0] cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-android-clang": No such file or directory (os error 2)
[boring-sys 5.2.0] CMAKE_PREFIX_PATH_x86_64-linux-android = None
[boring-sys 5.2.0] CMAKE_PREFIX_PATH_x86_64_linux_android = None
Collaborator
|
#529 has an alternative approach to exclude non-BoringSSL symbols that should be more robust. Are the "ptr casts" and Clippy changes still needed? I don't see any warnings in a recent run, and neither have these commits been applied to current master yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust started warning about incompatible redefinitions of
malloc.Boring headers pull in C stdlib, and
bindgenisn't very good at filtering out its unused/irrelevant symbols.This change excludes about 3000 lines of boilerplate from the bindings. I couldn't simply exclude
__.*, because macOS uses a pattern oftime_t = __darwin_time_t, and bindgen would naively leave it broken instead of following the aliases.