Repository navigation
integration: Use minion pools by default - #538
Open
claudiubelu wants to merge 1 commit into
Open
claudiubelu wants to merge 1 commit into
claudiubelu wants to merge 1 commit into
Conversation
Change ReplicaIntegrationTestBase to use minion pools by default if the providers supports them, instead of only in Minion-specific test classes. If a provider doesn't support minion pools, temporary workers will be used instead. These minion pools will be created once per test run, instead of per class (setUpClass), meaning that they will be reused across multiple tests. Minion pool-specific tests that disrupt the minion pool will create their own instead. Some tests will still use temporary workers, as they still need to be tested.
claudiubelu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
ReplicaIntegrationTestBaseto use minion pools by default if the providers supports them, instead of only in Minion-specific test classes. If a provider doesn't support minion pools, temporary workers will beused instead.
These minion pools will be created once per test run, instead of per class (
setUpClass), meaning that they will be reused across multiple tests. Minion pool-specific tests that disrupt the minion pool will createtheir own instead.
Some tests will still use temporary workers, as they still need to be tested.