Repository navigation
fix(bump): push the branch and release tag atomically - #41
Merged
Merged
Conversation
Separate pushes let CI triggered by the branch push check out before the tag lands, so hatch-vcs builds a dev version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bump pushing the branch and the release tag separately. It now runs
git push --atomic origin HEAD refs/tags/<tag>, so both refs land together or not at all.With dynamic versioning, CI triggered by the branch push could check out before the tag existed, so hatch-vcs derived a dev version (
1.4.28.devN+g…) for the release commit. core-api hits this since it skips tests for changelog-only commits and starts building within a minute (climate-resource/core-api#76).git push, since it has no tag.