Repository navigation
Conversation
…ts to a selection A change to a crate's tier or target-tier, or to .github/workflows/ci.yml, now selects every crate (rule 7 wants a full verification for a tier raise). 'crates --changed', 'verify --part base|miri --changed' and 'verify --part assemble --only' let a pull request verify only the selected crates; assemble then ends in CHANGED CRATES PASSED, never ALL CHECKS PASSED. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Pushes to main and manual runs still verify every crate. The job named Full verification keeps its name and reports a partial run as such. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…table comparison README.md's table can lack rows for crates a pull request did not measure (and lags main until the table job commits), so comparing it there would fail spuriously. Main's full run compares and writes it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a pull request, CI now verifies only the crates the PR changes and the crates that depend on them, instead of all 22. Pushes to
main, and manual runs, still verify every crate.What runs on a pull request
cargo xtask crates --changed origin/mainuses the existingchanged::select, against the merge base withmain. A stacked PR's selection also includes the lower PRs' crates. That over-selects, which is safe.Cargo.lock, the workspace manifest, toolchain pins,scripts/andxtask/;.github/workflows/ci.yml;tierortarget-tier, compared line by line with the merge base. A tier raise therefore still gets a full verification, as CLAUDE.md rule 7 requires.base,base-macos,miri: fmt, clippy and the static checks still cover the whole workspace. Tests and Miri are narrowed to the selected crates.cratematrix: only the selected groups run. The job is skipped when nothing is selected.Full verification(assemble): the name is unchanged.cratejob is accepted only when nothing was selected.CHANGED CRATES PASSED (n of m …), neverALL CHECKS PASSED.table: unchanged. It runs only onmain, and xtask refuses--writetogether with--only, so the table is only ever written from a full run.Docs
CLAUDE.md (rule 7's first bullet and the Workflow "done" sentence),
docs/VERIFICATION.md, theci.ymlheader and one README sentence now describe partial PR runs. Done still requires the PR's CI to be green andmain's full run after the merge to be green.Checks done
cargo test -p xtask: 65 passed, including new tests for theci.ymland tier rules.cargo xtask checkpasses.clazel-percentsource change selects 11 of 22 crates;ci.ymlchange selects all 22;Not tested yet
The GitHub expressions have not run anywhere: the empty-matrix skip,
toJSON(needs)withjq, andfetch-depth: 0on the merge ref. This PR touchesxtask/andci.yml, so it selects every crate and won't exercise the partial path. The first crate-only PR after it will.Branch protection: if it requires individual
Verify <crate>checks, those won't appear on PRs that don't select those crates, and the PR will be blocked. Requiring onlyFull verificationavoids this.🤖 Generated with Claude Code