Repository navigation
clazel-pkcs1: RSASSA-PKCS1-v1_5 verification (3.5c), tier 0 - #11
Merged
Merged
Conversation
clazel-pkcs1 (RSASSA-PKCS1-v1_5 verification, Phase 3 item 3.5c), taken unchanged from phase3/tls-handover so it can land on its own instead of inside #1, with the xtask converter for its vendored Wycheproof vectors and the allowlist rows for test-only sha2 and its dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolves conflicts in Cargo.lock (regenerated with cargo update --workspace --offline; no version changes), docs/DEPENDENCIES.md (rows from both sides) and xtask/src/testdata.rs (wycheproof_rsa and x509_limbo both registered). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
atiernan
marked this pull request as ready for review
October 28, 2026 06:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of the stacked PRs that replace #1 (TLS takeover plan, step 1). It is independent of #10. This adds
crates/clazel-pkcs1exactly as it is onphase3/tls-handover, with its vendored Wycheproof RSA PKCS#1 vectors, thextask testdataconverter for them (xtask/src/testdata/wycheproof_rsa.rs), and the allowlist rows for test-onlysha2and its six dependencies. Thesha2row no longer mentionsclazel-tls; that use returns with the TLS PR.The
xtaskchange makes CI check every crate.Local results:
cargo xtask checkreported STATIC CHECKS PASSED.cargo fmt --all --checkand strict clippy (clazel-pkcs1,xtask) are clean, andcargo test -p clazel-pkcs1passes (5 conformance tests, 198 s in a debug build). I did not run Verus, Kani, mutations or a full verify locally. The crate stays attier = 0.Needs Alex's OK to merge.
🤖 Generated with Claude Code