build(deps-dev): bump vitest from 4.1.11 to 5.0.2 - #339
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
Deploying podnotes with
|
| Latest commit: |
d132803
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4b1a81b2.podnotes.pages.dev |
| Branch Preview URL: | https://dependabot-npm-and-yarn-vite-o2o1.podnotes.pages.dev |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Requesting changes. Do not merge this lockfile-only Vitest 5 bump.
This is a semver-major deps-dev update (vitest 4.1.11 → 5.0.1). It is the same blocker as closed #336 (5.0.0): 5.0.1 does not fix the matcher type mismatch, so GitHub Test is already red.
What is fine
- Diff is
package.json+package-lock.jsononly. npm cion Node 22.22.2 succeeds and does not rewrite the lockfile.npm run lintandnpm run format:checkpass.npm audit --omit=devis clean (remaining highs are the samesharp/miniflare/wranglerdocs-deploy chain as master).- Runtime Vitest 5.0.1: 78 files / 1152 tests passed when typecheck is skipped.
- Production plugin code is unaffected (devDependency; not in
main.js). - Title is
build(deps-dev):, so this would not cut a plugin release.
Blocker: typecheck / svelte-check / CI Test
npm run typecheck (tsconfig.test.json) and svelte-check --fail-on-warnings both fail with 42 errors in 7 files. GitHub Test failed at the typecheck step, so npm run test never reaches Vitest in CI.
Missing matchers: toBeInTheDocument, toBeDisabled, toHaveClass, toHaveAttribute, toBeVisible on Assertion<void, HTMLElement>.
Cause: Vitest 5 inlined expect and changed matcher types to two-parameter Assertion<R, T> / Matchers<R, T>. Latest @testing-library/jest-dom@7.0.1 (and current main) still augments one-parameter Assertion<T>. TypeScript will not merge those, so tsconfig.test.json types (vitest/globals + @testing-library/jest-dom) no longer attach. Switching setup from @testing-library/jest-dom to @testing-library/jest-dom/vitest does not fix this until jest-dom updates the declaration arity.
Other Vitest 5 items for a dedicated migration (not this PR)
clearMocksnow defaults totrue(runtime suite still passed; decide explicitly invitest.config.ts).- Unawaited
.resolves/.rejectsnow fail (this suite already awaits them). - Node / Vite prerequisites are already met (Node 22, Vite 8.3.0).
Required path
Do not land this Dependabot-only major. Open a dedicated migration that:
- Adds a local
declare module "vitest"ambient matchingAssertion<R, T>(or waits for a jest-dom release that does). - Makes
clearMocksan explicit config choice. - Passes
npm run typecheck,npm run test(svelte-check + Vitest), and GitHubTest.
Sent by Cursor Automation: Dependabot PRs
| "typescript": "6.0.3", | ||
| "vite": "^8.3.0", | ||
| "vitest": "^4.1.11", | ||
| "vitest": "^5.0.1", |
There was a problem hiding this comment.
Vitest 5.0.1 is still a breaking major versus 4.1.11. This repo’s tsconfig.test.json pulls in @testing-library/jest-dom types, and 7.0.1 still augments one-parameter Assertion<T> while Vitest 5 exports Assertion<R, T>. That mismatch is why npm run typecheck / svelte-check fail (42 errors) and GitHub Test is red, even though a direct vitest --run passes 1152 tests.
Do not merge this pin by itself. A dedicated migration needs a two-parameter ambient matcher declaration (jest-dom main has not shipped one) plus an explicit clearMocks decision — Vitest 5 defaults it to true.
e47c4e5 to
388139c
Compare
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 4.1.11 to 5.0.2. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.2/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-version: 5.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
changed the title
388139c to
d132803
Compare
Bumps vitest from 4.1.11 to 5.0.2.
Release notes
Sourced from vitest's releases.
... (truncated)
Commits
428e2e5chore: release v5.0.2 (#11357)0b79231fix: bindprocessin case global is overwritten (#11343)597df56docs: correct stale config defaults (#11354)ea1c44fdocs:sequence.setupFilesdefault is'list'(#11351)0fd6b97fix(detect-async-leaks): ignoreprocess.stdiohandles (#11333)4e91e56fix(reporters):hanging-processto use ESM entrypoint (#11316)1a57929docs(browser): fix locators.exact default (#11338)5b95efbfix(reporter):agentto respect--silent(#11271)f58a209docs: correct benchmark.exclude and watch defaults (#11268)d1c3eccfix(jsdom): fixRequestwithBlobbody on jsdom 28+ (#11295)