Skip to content

Release 4.9.3: grant contents write to the release job - #268

Merged
david-ruiz-cko merged 2 commits into
mainfrom
fix/release-job-permissions
Nov 6, 2026
Merged

david-ruiz-cko merged 2 commits into
mainfrom
fix/release-job-permissions

Conversation

@robert-goheen-cko

@robert-goheen-cko robert-goheen-cko commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The repository's default GITHUB_TOKEN is now read-only. build-release.yml has no permissions: block, so the create-release step fails with "Resource not accessible by integration" after the package is uploaded to PyPI. This happened for 4.9.1 and 4.9.2: both are on PyPI, but neither has a tag or GitHub release.

Changes

  • .github/workflows/build-release.yml: add permissions: contents: write to the deploy job.
  • checkout_sdk/properties.py: bump the version to 4.9.3. Merging this PR runs build-release, which publishes 4.9.3 to PyPI and creates its tag and GitHub release. That also tests the permissions fix. 4.9.3 has no SDK code changes since 4.9.2.

After merging

  • Check that the build-release run creates the 4.9.3 tag and GitHub release.
  • Create the missing tags and releases for 4.9.1 (22ada34) and 4.9.2 (c93b91c) with gh release create.
  • Don't re-run the failed 4.9.1 or 4.9.2 release runs. PyPI rejects files it already has, so they fail at the upload.

This is a stopgap until #264, which sets permissions per job and replaces actions/create-release.

🤖 Generated with Claude Code

The repository's default GITHUB_TOKEN is now read-only, so the
create-release step can no longer create the version tag and GitHub
release. Give the deploy job contents: write.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@agent-wall-e

agent-wall-e Bot commented Nov 6, 2026

Copy link
Copy Markdown

🔴 Risk Classification: MAJOR

Approval route: AI Review + Human Approval Required
Rollback controls: Change-freeze window + documented rollback plan

Classification reasons

  • security_sensitive_path:.github/workflows/build-release.yml

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Nov 6, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
security_sensitive_path — .github/workflows/build-release.yml classifying §2.1 M4/M5 Path matched a sensitive pattern (auth, secrets, crypto, PCI, migrations, network IaC).

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

🔵 Advisory review: Sound, but needs your judgement

This PR needs a human approval. The code itself reads as correct; whether it should land depends on context I don't have.

Adds permissions: contents: write to the deploy job to fix GitHub release creation, and bumps the version to 4.9.3. The fix is technically correct, but a human should confirm the version bump and release sequencing are intentional given that 4.9.1 and 4.9.2 already exist on PyPI without corresponding GitHub releases.

For you to decide

  • The permissions: contents: write block is placed correctly on the deploy job and directly addresses the 'Resource not accessible by integration' failure described.
  • The version bump from 4.9.2 to 4.9.3 is included in this PR; a reviewer should confirm this is intentional and that a 4.9.3 release is ready, rather than this being an accidental commit alongside the CI fix.
  • The PR description says the missing 4.9.1 and 4.9.2 tags/releases should be created manually after merging — a reviewer should confirm there is a plan to do that, since this PR does not automate it.
  • The workflow still uses actions/checkout@v2, which is unpinned and outdated, but that is a pre-existing issue not introduced here.

This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02

Bump the version so that merging runs build-release and publishes a new
version to PyPI. 4.9.1 and 4.9.2 already exist on PyPI and can't be
uploaded again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@agent-wall-e

agent-wall-e Bot commented Nov 6, 2026

Copy link
Copy Markdown

🔴 Risk Classification: MAJOR

Approval route: AI Review + Human Approval Required
Rollback controls: Change-freeze window + documented rollback plan

Classification reasons

  • security_sensitive_path:.github/workflows/build-release.yml

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 2


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Nov 6, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
security_sensitive_path — .github/workflows/build-release.yml classifying §2.1 M4/M5 Path matched a sensitive pattern (auth, secrets, crypto, PCI, migrations, network IaC).

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@robert-goheen-cko robert-goheen-cko changed the title ci(release): grant contents write to the release job Release 4.9.3: grant contents write to the release job Nov 6, 2026
@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

@david-ruiz-cko
david-ruiz-cko merged commit bd24e10 into main Nov 6, 2026
4 checks passed
@david-ruiz-cko
david-ruiz-cko deleted the fix/release-job-permissions branch November 6, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants