Repository navigation
fix(client): security hardening - #478
Conversation
🔴 Risk Classification: MAJORApproval route: AI Review + Human Approval Required Classification reasons
Operational gates
Files analysed: 7 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
🟢 Advisory review: Looks good to meThis PR still needs a human approval — wall-e cannot auto-approve it. For what it's worth, I read the diff and found nothing I'd block on. Security hardening of the OAuth authentication client: fixes token expiry math (seconds→ms), adds a 60s refresh margin, prevents credential leakage in errors, fixes mutation of shared config in sessions.js, and unifies GooglePay/OnboardingSimulator/Tokens to use the standard auth path. The diff matches its stated intent and the changes read as correct. What I checked
This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02 |
🔴 Risk Classification: MAJORApproval route: AI Review + Human Approval Required Classification reasons
Operational gates
Files analysed: 7 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
🔴 Risk Classification: MAJORApproval route: AI Review + Human Approval Required Classification reasons
Operational gates
Files analysed: 8 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
🔴 Risk Classification: MAJORApproval route: AI Review + Human Approval Required Classification reasons
Operational gates
Files analysed: 8 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
|



Summary
Security hardening of the authentication client. No public signature changes.
Changes
src/services/http.js: security hardening of the authentication clientsrc/api/access/access.js: security hardening of the authentication clientsrc/Checkout.js: initialise the access token holder once per clientsrc/api/google-pay/google-pay.js,src/api/onboarding-simulator/onboarding-simulator.js,src/api/tokens/tokens.js: authenticate through the shared path, like the rest of the SDKsrc/api/sessions/sessions.js: per-request headers on a copied config, ascards.updateCarddoestest/http/tokenHandling.js: new unit testsAPI Reference
None.
Breaking changes
None to documented usage.
config.accessis now an empty object before the first OAuthrequest instead of
undefined; to check for a token, readconfig.access.token.Tests
npm run build)Related
None.