Conversation
Send `timezone: null` when the property is omitted. Project deploys update maintenance windows as a patch, so an omitted timezone kept the stored zone and removing it from code had no effect. Add a `TimeZone` type that suggests canonical IANA names (tzdata 2026c zone.tab plus UTC) while still accepting any string, and reject UTC offsets and unknown zone names during validation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With `tags` optional, a window can set neither a pause scope nor a silence scope and would deploy without affecting any check, so validation now warns about it. Import codegen emits `tags` only when the window has some, the time zone check moves next to the `TimeZone` type, and the AI context describes the silence scope and `timezone`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sorccu
force-pushed
the
manel/parity-maintenance-window-scope
branch
from
September 29, 2026 17:35
08c00e7 to
0250a1c
Compare
sorccu
changed the title
sorccu
marked this pull request as ready for review
September 29, 2026 17:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: RED-1015
Adds
timezone,pauseAllChecks,silenceAlertsTagsandsilenceAllAlertsto theMaintenanceWindowconstruct, and makestagsoptional. The CLI deploy schema already accepts all of these, so no backend change is needed.checkly importround-trips the new properties.timezoneis sent asnullwhen omitted. Project deploys update maintenance windows as a patch: a missingtimezonekeeps the stored zone, so deleting it from code would otherwise do nothing. Withnull, removing it resets the window to UTC. The other three fields don't need this because the deploy schema defaults them when they're omitted.TimeZonetype. Editors suggest the canonical IANA names (tzdata 2026czone.tabplusUTC), and any other string is still accepted. The list uses current names such asEurope/Kyiv, not the legacy CLDR idsIntlreturns, because the API stores current names.Validation.
validate()rejects UTC offsets (+05:00,Etc/GMT+5), which the API also rejects, and names thatIntldoesn't recognize. Listed names skip theIntlcheck, because older Node releases ship older tzdata.Warning for a window with no scope. Now that
tagsis optional,validate()warns (without failing) when a window sets neither a pause scope (tags/pauseAllChecks) nor a silence scope (silenceAlertsTags/silenceAllAlerts). Such a window would affect no checks.Upgrade note. The first deploy after upgrading resets any timezone set for a CLI-managed window in the web app. If a maintenance is active at that moment, the deploy fails until the maintenance ends, because the API rejects timezone changes on an active window. The fix is to declare the timezone in code.
Related:
🤖 Generated with Claude Code