Repository navigation
Switch dependency installs to uv - #70
Merged
Merged
Conversation
Replace the requirements files with locked uv projects for the scripts and the image picker, and install those locks in both Docker images. Co-authored-by: chaz <chaz@chazlarson.com>
chazlarson
marked this pull request as ready for review
October 21, 2026 01:34
| @@ -1,25 +0,0 @@ | |||
| alive-progress==2.4.1 | |||
There was a problem hiding this comment.
Removing requirements.txt leaves .github/workflows/CI.yml pointing at a file that no longer exists; a manual workflow_dispatch run, or any future master-targeted run, will fail in the dependency-install steps before tests or packaging can start.
Severity: medium
🤖 Was this useful? React with 👍 or 👎
|
👀 Human review needed JustificationThis PR migrates dependency installation from
However, this change rewrites production deployment artifacts and lacks automated verification:
Recommend a human confirm both Docker images build and the orchestrator and picker services start under the uv-based install before merging. Reviewed commit e109802 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scripts and the Plex Image Picker now install from uv lockfiles instead of
requirements.txt.pyproject.toml/uv.lockcovers the orchestrator and the Plex, Kometa, and TMDB scripts. Python is pinned to 3.12.ruffandpre-commitare in the dev group, so production installs skip them.plex-image-picker/is its own uv project, withpylintin its dev group. Its image moved from Python 3.9 to 3.12.uv sync --frozen --no-dev --no-install-project.direnvrunsuv syncand activates.venv. Without direnv:uv sync, thenuv run.TMDB/requirements.txt(it still listedpython-dotenv) is gone, along with the pre-commitrequirements-txt-fixerhook..github/workflows/CI.ymlis unchanged. It only runs onmaster, still installsrequirements.txt, and is the copied LizardByte plugin workflow (Python 2.7 tests, bundle packaging). It does not run onmain.Verification
uv lockanduv syncfor both projects on CPython 3.12.3.import yaml, plexapi, requests, flaskandcompilealloforchestrator.pyandmenu.py.import flask, plexapi, requests.