Skip to content

test: the live suite passes on v3.1.0 again - #178

Open
catborise wants to merge 1 commit into
masterfrom
live-sata-refusal
Open

catborise wants to merge 1 commit into
masterfrom
live-sata-refusal

Conversation

@catborise

Copy link
Copy Markdown
Owner

I ran the full live suite against v3.1.0 on the Vagrant computes, as the README describes. There were three runs of 1505 tests each:

  • TCP to compute1 and SSH to compute2, with migration, LVM, iSCSI and NFS;
  • TLS to compute1;
  • a socket inside compute1.

The product passed. Two tests failed because they no longer matched the code:

Test Runs Cause Fix
test_a_sata_disk_cannot_be_added_to_a_running_vm_and_nothing_changes all three Since 90c148d, a form that libvirt refuses goes back to its page with the reason instead of returning a 500. The test still expected the 500. Expect the redirect and the "libvirt Error" message. The checks that neither definition changed and that the new volume stays are kept.
NvramCopyTestCase.test_the_copy_is_deleted_when_the_definition_fails socket only libvirt-python gives a new libvirtError the message of the last error its thread recorded. Here that was "client socket is closed", from a connection an earlier live test had left behind. Reproduced with a deliberate earlier error. Assert that the test's own error object is raised, instead of matching its text.

Verification

  • The SATA test passes live on compute1 (TCP).
  • The migration tests pass.
  • The full suite passes: manage.py test --parallel, 1388 tests OK.

These are test-only changes. Nothing in v3.1.0 itself is affected, so no new release is needed.

🤖 Generated with Claude Code

The live suite run against v3.1.0 on two Vagrant computes (TCP and SSH,
TLS, a socket inside compute1) found two tests that no longer held, and
nothing else:

- A SATA disk added to a running VM is refused by libvirt; since
  90c148d a refused form goes back to its page with the reason instead
  of a 500. The test expected the 500; it now expects the redirect and
  the message, and still checks that neither definition changed.
- The NVRAM copy test built its libvirtError("define failed") and
  matched that text, but libvirt-python gives a new libvirtError the
  message of the last error its thread recorded: in the socket run a
  connection of an earlier live test was closed by then ("client socket
  is closed"). The test now checks that its own error object is raised.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant