Repository navigation
Conversation
The live suite run against v3.1.0 on two Vagrant computes (TCP and SSH, TLS, a socket inside compute1) found two tests that no longer held, and nothing else: - A SATA disk added to a running VM is refused by libvirt; since 90c148d a refused form goes back to its page with the reason instead of a 500. The test expected the 500; it now expects the redirect and the message, and still checks that neither definition changed. - The NVRAM copy test built its libvirtError("define failed") and matched that text, but libvirt-python gives a new libvirtError the message of the last error its thread recorded: in the socket run a connection of an earlier live test was closed by then ("client socket is closed"). The test now checks that its own error object is raised.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran the full live suite against v3.1.0 on the Vagrant computes, as the README describes. There were three runs of 1505 tests each:
The product passed. Two tests failed because they no longer matched the code:
test_a_sata_disk_cannot_be_added_to_a_running_vm_and_nothing_changesNvramCopyTestCase.test_the_copy_is_deleted_when_the_definition_failslibvirtErrorthe message of the last error its thread recorded. Here that was "client socket is closed", from a connection an earlier live test had left behind. Reproduced with a deliberate earlier error.Verification
manage.py test --parallel, 1388 tests OK.These are test-only changes. Nothing in v3.1.0 itself is affected, so no new release is needed.
🤖 Generated with Claude Code