Repository navigation
chore(ci): the console lane runs on a PR only when it changes what the lane exercises, in Chromium only - #413
Merged
Merged
Conversation
…e lane exercises, in Chromium only
…er, and a moved file counts by its old path too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Console job (three browsers, about 15 minutes) ran on every push of every PR, including agent-config, ADR and docs PRs it cannot affect. CI runners queued for up to two hours during the #358/#359 runs.
Changesjob lists the PR's changed files, renames by both paths. Console runs when one is a source file undersrc/orui/(unit tests excluded), a console spec, its fixtures or helpers,playwright.config.ts,package.json, the lockfile, a roottsconfig*.json, orci.yml. On the last 25 merged PRs it would have skipped 12.on.pull_request.paths: Console is a required check. A workflow skipped by a path filter leaves its checks pending, which blocks the merge; a job skipped byif:reports success. IfChangesitself fails, Console runs.ui/, the console specs orplaywright.config.tsruns all three browsers; any other PR runs Chromium only. Every push tomainruns all three. Of the last 10 Console failures, 6 were Firefox- or WebKit-only. This rule would have caught 3 of them; 2 came from PRs with no UI change (feat(core): the warm pool module: one budget, a keep rule that fits, and an off switch #386, chore(agents): agents run only the tests their change reaches; hooks run the other checks #379), so their kind now shows up only onmain.toolchain.mdandDELIVERY.mdsay when the lane runs.Written by an agent.