Repository navigation
chore(agents): implementer audits its diff before reporting - #377
Merged
Merged
Conversation
Four questions before the suite runs: what the diff took away, what it replaced, what new code accepts that it should not, and what it promised. Fix mode re-runs the audit; the report gains an Audit line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent delivery PRs (#374, #375) took review rounds for misses one search or one probe would have caught: stale comments and docs after a rename, test titles whose setup was edited after red, Done when lines ticked without a test, and a replacement check with holes the old one covered.
The implementer now answers four general questions before running the suite:
The test self-check also covers tests edited after the red commit, fix mode re-runs the audit, and the report gains an
Audit:line with counts.Written by an agent.