fix(laminar): bound diagnostic span and export memory - #164
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Fix all with cubic | Re-trigger cubic
|
Verified in shared staging after merging BrowserCode #164 and Cloud #6142, #6143, #6140.
Limits: the local memory benchmark is not a staging RSS measurement; these checks do not establish that every historical OOM cause is eliminated. Production transport, mixed-version rollout, and production memory behavior still need release monitoring. No production deployment or manual AWS changes were made. |
Large diagnostic strings and count-only queues let tracing consume excessive worker and control-plane memory. This bounds diagnostic text to 16 KiB, encoded records to 64 KiB, uploads to 1 MiB, and pending diagnostics to 4 MiB or 512 records, preserving original task input and marking truncation. Verification: 14 tests and the configured monorepo typecheck pass, covering UTF-8 bounds, identity and usage preservation, queue recovery, real HTTP 413 without retry, and an attribute-key collision reproduced red then fixed green (evidence). Release this sender and update the Cloud worker pin before deploying the receiver change; older in-flight workers and chunked connection-reset behavior still need compatibility verification. Sender tests also verify timeout recovery, schema preservation, and near-limit encoded uploads; staging deployment follows the released worker pin.
Summary by cubic
Bounds tracing memory usage so large diagnostic strings and stalled exporters can no longer exhaust worker and control-plane memory.
bcode.telemetry.truncatedwhile preserving the original task input.@opentelemetry/otlp-transformerand@opentelemetry/resourcesand reduces the export timeout from 30 s to 10 s.Draft with local synthetic test evidence only; nothing deployed. Requires the Cloud worker pin to be updated before deploying the companion receiver change.
Written for commit 12a406f. Summary will update on new commits.