Show the short request ID of log lines - #56
Merged
Merged
Conversation
Bref's log formatters start lines with the Lambda request ID, and Bref Cloud returns it as `request_id`. Show its first 8 characters after the instance, like the dashboard: enough to tell requests apart, and to find all the logs of one with `--search=<id> --all`. Claude-Session: https://claude.ai/code/session_0168N55uBK9UjfpL6r8oGjDm
Two unlabeled IDs side by side were confusing. Logs without request IDs (older versions of Bref's log formatters) keep the instance. Claude-Session: https://claude.ai/code/session_0168N55uBK9UjfpL6r8oGjDm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bref's log formatters now start each line with the Lambda request ID (brefphp/monolog-bridge 2.0, brefphp/logger 3.0), and Bref Cloud returns it in the
request_idfield ofbref logsrecords (it already parses the lines, so the message itself has no prefix).bref logsnow shows its first 8 characters after the function, like the dashboard does, instead of the instance:That is enough to tell the requests of a page apart, and to see all the logs of one:
bref logs --search=092cf7a5 --all. Lines without a request ID (a cold start, a PHP-FPM error) get a blank column.A single ID column rather than the instance and the request ID side by side, which read as two unlabeled IDs. Logs without any request ID (applications on older versions of Bref's packages) keep the instance column as before.
--jsonstill has bothinstanceand the fullrequest_id.Rendering only: older CLI versions ignore the new field.