You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Windows CI does not fail if one or more tests fail #521
While I was working on updating the Windows CI, I noticed that some tests were failing, but the test suite -- and the GitHub Actions workflow as a whole -- succeeded anyway. We should probably change that.
faber prints a test summary with overall stats that should indicate how many real errors were observed in the run. (And it is supposed to fail the overall call if unexpected failures were encountered.)
I was working on a Pull Request anyway, and among other things, I was trying to fix the caching of vcpkg dependencies, but I'm not having much luck, so I'll probably just close it.
Activity
stephengtuggy commentedon Jun 27, 2026
OK, maybe I was mistaken. All the errors and failures I'm seeing now are expected errors or
XFAILs. So everything is passing after all, it seems.stefanseefeld commentedon Jun 28, 2026
faberprints a test summary with overall stats that should indicate how many real errors were observed in the run. (And it is supposed to fail the overall call if unexpected failures were encountered.)stephengtuggy commentedon Jun 28, 2026
@stefanseefeld Understood.
I was working on a Pull Request anyway, and among other things, I was trying to fix the caching of vcpkg dependencies, but I'm not having much luck, so I'll probably just close it.
stephengtuggy commentedon Jun 28, 2026
vcpkg caching seems to be working now! PR #522 is ready.