Skip to content

Fixed parsing atom_id when reading GRO files - #971

Open
GabiAxel wants to merge 1 commit into
biotite-dev:mainfrom
GabiAxel:master
Open

GabiAxel wants to merge 1 commit into
biotite-dev:mainfrom
GabiAxel:master

Conversation

@GabiAxel

Copy link
Copy Markdown

GROFile.getStructure did not contain any code for parsing and storing the atom_id column. This PR fixes it and allows access to the atom_id field.

@padix-key padix-key left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feature, this looks good to me. Could you run ruff on this PR? The code style check is currently failing

@codspeed

codspeed Bot commented Oct 24, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 11.91%

⚡ 2 improved benchmarks
✅ 107 untouched benchmarks
⏩ 14 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ benchmark_match_kmer_selection[KmerTable-11*11*1*1***111] 277.4 µs 244.2 µs +13.6%
⚡ benchmark_match[KmerTable-11*11*1*1***111] 376.1 µs 341.1 µs +10.25%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing GabiAxel:master (ae6de41) with main (67df9a4)

Open in CodSpeed

Footnotes

  1. 14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@GabiAxel

Copy link
Copy Markdown
Author

I fixed the code style issue.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants