Repository navigation
feat - Return Makeswift page identity headers from the local renderer - #1419
Merged
Conversation
parthshahp
added this pull request to stack #1417
October 8, 2026 20:08
parthshahp
commented
Oct 8, 2026
rtalvarez
reviewed
Oct 8, 2026
| } | ||
| // Headers that a tunnel request can carry and that must not go to the store: the preview | ||
| // headers, the dispatch router headers, and Cloudflare and cloudflared request metadata. | ||
| const HOP_HEADER_PREFIXES = ['x-stencil-preview-', 'x-bc-makeswift-', 'cf-']; |
Member
There was a problem hiding this comment.
I wonder if these deletions are even needed at this point 🤔
Contributor
Author
There was a problem hiding this comment.
Removed that commit completely, this PR now only contains the makeswift required headers.
parthshahp
force-pushed
the
parthshah/ltrac-2121-stencil-cli-return-makeswift-page-identity-headers-from-the-local
branch
from
October 9, 2026 15:06
57199c3 to
cb3aeba
Compare
parthshahp
changed the title
parthshahp
force-pushed
the
parthshah/ltrac-2121-stencil-cli-return-makeswift-page-identity-headers-from-the-local
branch
from
October 16, 2026 14:31
cb3aeba to
3d8bd16
Compare
rtalvarez
approved these changes
Oct 19, 2026
* feat: automatically install cloudflared for Makeswift preview * fix: stop Makeswift preview when cloudflared exits unexpectedly
parthshahp
force-pushed
the
parthshah/ltrac-2121-stencil-cli-return-makeswift-page-identity-headers-from-the-local
branch
from
October 19, 2026 19:06
fe367f7 to
41b9258
Compare
Contributor
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Two changes for the Makeswift tunnel preview. Reviewing by commit will make this easier.
x-stencil-preview-*headers, the dispatch router headers (x-bc-makeswift-*,x-bc-stencil-worker-name,x-platform-dispatch-router-proxy), and Cloudflare andcloudflaredmetadata (cf-*,cdn-loop). The renderer and the router proxy routes now remove them before the request goes to the store. In preview mode, the renderer sendsx-platform-dispatch-router-proxy: 1, so the store request goes directly to origin and does not go through the Makeswift worker again.PencilResponsecopied onlyset-cookiefrom the Storefront response. The worker needsx-makeswift-stable-page-referenceto find the Makeswift content for a page. Without it, the worker returns the page without Makeswift content. The renderer now also returnsx-makeswift-stable-page-reference,x-makeswift-page-locale, andx-makeswift-storefront-tokenwhen Storefront sends them. The worker removes the token before the response goes to the browser.Tickets / Documentation
cc @bigcommerce/storefront-team