Skip to content

feat: Revoke the Makeswift preview session and stop the tunnel on exit - #1416

Merged
parthshahp merged 2 commits into
parthshah/ltrac-1796-stencil-cli-session-heartbeat-and-re-registration-on-expiryfrom
parthshah/ltrac-1797-stencil-cli-tunnel-and-session-cleanup-on-exit
Oct 19, 2026
Merged

parthshahp merged 2 commits into
parthshah/ltrac-1796-stencil-cli-session-heartbeat-and-re-registration-on-expiryfrom
parthshah/ltrac-1797-stencil-cli-tunnel-and-session-cleanup-on-exit

Conversation

@parthshahp

@parthshahp parthshahp commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

What?

  • Revoke the Makeswift preview session and stop the tunnel when stencil start exits.
  • Refactor: move the Makeswift preview lifecycle out of stencil-start into MakeswiftPreview.

Reviewing by commit will make this easier; the first contains the request to revoke the preview session / stop the tunnel on exit, while the second contains the refactor (no behavior change).

Tickets / Documentation

Demo

Screen.Recording.2026-10-08.at.10.23.29.AM.mov

cc @bigcommerce/storefront-team

@parthshahp
parthshahp added this pull request to stack #1417 October 8, 2026 15:17
@parthshahp
parthshahp force-pushed the parthshah/ltrac-1797-stencil-cli-tunnel-and-session-cleanup-on-exit branch from cc9e50a to 47bbac5 Compare October 8, 2026 15:18
@parthshahp
parthshahp marked this pull request as ready for review October 8, 2026 17:56
@parthshahp
parthshahp force-pushed the parthshah/ltrac-1797-stencil-cli-tunnel-and-session-cleanup-on-exit branch from 47bbac5 to 4c8e1cc Compare October 9, 2026 15:06
@parthshahp
parthshahp force-pushed the parthshah/ltrac-1797-stencil-cli-tunnel-and-session-cleanup-on-exit branch from 4c8e1cc to faa3b74 Compare October 16, 2026 14:31
@parthshahp
parthshahp force-pushed the parthshah/ltrac-1797-stencil-cli-tunnel-and-session-cleanup-on-exit branch from faa3b74 to bb3ba45 Compare October 19, 2026 19:06
@parthshahp
parthshahp merged commit 5432b2b into master Oct 19, 2026
4 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants